Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add a line of RenderBoxes to the display list if it doesn't intersect. #228

Closed
burg opened this issue Nov 21, 2012 · 3 comments
Closed

Comments

@burg
Copy link

@burg burg commented Nov 21, 2012

Currently we add inline flows all at once, without seeing if only part of the inline flow intersects the region necessary. This should really cut down time spent creating display list/rendering for large inlines.

ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
webdriver: relocate tests from hg to git and the webplatform tests.
@shinglyu
Copy link
Member

@shinglyu shinglyu commented Dec 29, 2014

I would like to take this. Can you point me to the related file? Thank you.

@jdm
Copy link
Member

@jdm jdm commented Dec 29, 2014

I believe this is already addressed by the code at http://mxr.mozilla.org/servo/source/components/layout/display_list_builder.rs#702 . @pcwalton, do you agree?

@jdm jdm removed the E-easy label Feb 20, 2015
@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 24, 2016

This is done.

@mbrubeck mbrubeck closed this May 24, 2016
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@pyfisch pyfisch mentioned this issue Jan 4, 2018
4 of 13 tasks complete
pyfisch added a commit to pyfisch/servo that referenced this issue Jan 4, 2018
* servo#228 was done (confirmed by mbrubeck)
* servo#2012 fixed TODO item
* servo/webrender#28 (zoom does work)
@pyfisch pyfisch mentioned this issue Jan 4, 2018
2 of 5 tasks complete
bors-servo added a commit that referenced this issue Jan 4, 2018
Remove mention of some old issues

* #228 was done (confirmed by mbrubeck)
* #2012 fixed TODO item
* servo/webrender#28 (zoom does work)

<!-- Please describe your changes on the following line: -->
See #19685

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19691)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 5, 2018
Remove mention of some old issues

* #228 was done (confirmed by mbrubeck)
* #2012 fixed TODO item
* servo/webrender#28 (zoom does work)

<!-- Please describe your changes on the following line: -->
See #19685

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19691)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 5, 2018
Remove mention of some old issues

* #228 was done (confirmed by mbrubeck)
* #2012 fixed TODO item
* servo/webrender#28 (zoom does work)

<!-- Please describe your changes on the following line: -->
See #19685

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19691)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.