Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not load the requested page: Unexpected scheme #22826

Closed
FruityWelsh opened this issue Feb 5, 2019 · 2 comments
Closed

Could not load the requested page: Unexpected scheme #22826

FruityWelsh opened this issue Feb 5, 2019 · 2 comments
Labels
A-webrender C-reproduced I-panic

Comments

@FruityWelsh
Copy link

@FruityWelsh FruityWelsh commented Feb 5, 2019

This is the error I get when I click on the facebook logo.

Could not load the requested page: Unexpected scheme
@jdm
Copy link
Member

@jdm jdm commented Feb 5, 2019

The debug output in my terminal suggests this is a panic in WebRender:

Tried to use WebRender SpatialId before it was defined. (thread LayoutThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(3) }, at src/libcore/option.rs:1038)
[2019-02-05T15:21:27Z ERROR servo] Tried to use WebRender SpatialId before it was defined.
@jdm
Copy link
Member

@jdm jdm commented Feb 5, 2019

I got this right after logging in while it was trying to display the homepage.
@jdm jdm mentioned this issue Nov 28, 2019
Closed
@jdm jdm mentioned this issue Dec 6, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 6, 2019
@bors-servo
Auto merge of #25158 - jdm:wr-spatial-panic, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ac4eb9 
Fix "Tried to use SpatialId before it was defined" layout panic

In the case where an element uses `text-overflow: ellipsis` and causes overflow, we create a TruncatedFragment that wraps the original overflowing fragment. When collecting stacking contexts for the truncated fragment, #18510 addressed the case where the wrapped fragment wouldn't be processed, but neglected the case where that fragment ends up creating a new stacking context. When that happens, the TruncatedFragment would be stuck with the updated scrolling/clipping information based on the new stacking context, but it would be a child of the parent stacking context. Since the new scrolling/clipping nodes do not exist in the display list until the new stacking context display item is created, this led to the observed panic.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24895 and #19281 and #22826.
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Dec 6, 2019
@bors-servo
Auto merge of #25158 - jdm:wr-spatial-panic, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
441bf24 
Fix "Tried to use SpatialId before it was defined" layout panic

In the case where an element uses `text-overflow: ellipsis` and causes overflow, we create a TruncatedFragment that wraps the original overflowing fragment. When collecting stacking contexts for the truncated fragment, #18510 addressed the case where the wrapped fragment wouldn't be processed, but neglected the case where that fragment ends up creating a new stacking context. When that happens, the TruncatedFragment would be stuck with the updated scrolling/clipping information based on the new stacking context, but it would be a child of the parent stacking context. Since the new scrolling/clipping nodes do not exist in the display list until the new stacking context display item is created, this led to the observed panic.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24895 and #19281 and #22826.
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Dec 9, 2019
@bors-servo
Auto merge of #25158 - jdm:wr-spatial-panic, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03c6389 
Fix "Tried to use SpatialId before it was defined" layout panic

In the case where an element uses `text-overflow: ellipsis` and causes overflow, we create a TruncatedFragment that wraps the original overflowing fragment. When collecting stacking contexts for the truncated fragment, #18510 addressed the case where the wrapped fragment wouldn't be processed, but neglected the case where that fragment ends up creating a new stacking context. When that happens, the TruncatedFragment would be stuck with the updated scrolling/clipping information based on the new stacking context, but it would be a child of the parent stacking context. Since the new scrolling/clipping nodes do not exist in the display list until the new stacking context display item is created, this led to the observed panic.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24895 and fix #19281 and fix #22826.
- [x] There are tests for these changes
@bors-servo bors-servo closed this in e8d677a Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-webrender C-reproduced I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix "Tried to use SpatialId before it was defined" layout panic
2 participants
@jdm @FruityWelsh
You can’t perform that action at this time.