Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try removing Reflectable from JS<T> types #2285

Closed
jdm opened this issue May 1, 2014 · 1 comment
Closed

Try removing Reflectable from JS<T> types #2285

jdm opened this issue May 1, 2014 · 1 comment
Labels
A-content/bindings

Comments

@jdm
Copy link
Member

@jdm jdm commented May 1, 2014

It may be possible to avoid it, and that would clean up some unsafe code after #2101 lands.
@nox
Copy link
Member

@nox nox commented Sep 12, 2015

That sounds quite outdated.
@nox nox closed this Sep 12, 2015
@Ms2ger Ms2ger reopened this Sep 13, 2015
@Ms2ger Ms2ger closed this in 3781567 Sep 13, 2015
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@Ms2ger @josiahdaniels
Stop implementing Reflectable for JS<T> (fixes servo#2285).
515b890 
It's not generally safe to expose the contents of a JS<T>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @Ms2ger @nox
You can’t perform that action at this time.