Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event dispatching and event listener/handler management does not match specification #22887

Open
jdm opened this issue Feb 13, 2019 · 0 comments
Open

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 13, 2019

There are various issues that I have noticed so far:

  • #13152
  • #22783
  • we ignore errors in CompiledEventListener::call_or_handle_event, rather than rethrowing
  • the spec for dispatching is much more complex than the one that our implementation was written against
  • the spec for getting an event handler is much more complex than the one that our implementation was written against

It would be good to align our implementation against the updated specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.