Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse origin of source document for MessageEvent resulting from postMessage #22888
Comments
|
Assign this to me please. |
|
@EllaLiu5 Have you made any progress? Do you have any questions? |
|
I'd be interested in trying this out! |
|
@yashpatel5400 Did you make any progress? Are you still working on this? |
|
Hey, it appears that no one is working on this one. If that's ok I can look into this task. |
|
Please do! |
|
@mmiecz Have you made any progress on this? |
|
Yes, the test is passing now, but I still have to clean up the code ( remove unwraps, etc. ). I will create PR soon, so you can make some comments, because I am not entirely sure about the solution. |
|
Hi, I am having some hardware problems since I’ve upgraded recently and I can’t boot to Linux where I have my servo code :( I am trying to resolve this issue right no, sorry for the delay! |
|
I've created a PR but I see it's already done? |
|
Closing since this was fixed by #23637. |
Right now
Window::post_messagepassesNoneas the value that will initializeMessageEvent.origin. The spec says this should be the origin of the source document that posted the message instead. We will want to add a new origin argument toWindow::post_message, and store the origin inScriptMsg::PostMessageas well so the code path inDissimilarOriginWindow::post_messagealso works.This should allow tests/wpt/web-platform-tests/dom/events/EventListener-incumbent-global-1.sub.html to make more progress.
Code:
components/script/dom/window.rs,components/script/dom/dissimilaroriginwindow.rs,components/script/script_thread.rs,components/script_traits/lib.rsTest:
./mach test-wpt tests/wpt/web-platform-tests/dom/events/EventListener-incumbent-global-1.sub.html