Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AudioParam.setValueCurveAtTime #22897

Closed
jdm opened this issue Feb 15, 2019 · 1 comment
Closed

Implement AudioParam.setValueCurveAtTime #22897

jdm opened this issue Feb 15, 2019 · 1 comment
Labels
A-content/webaudio
Projects
WebAudio

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 15, 2019

This requires implementing the backend processing in servo/media#204, then uncommenting the WebIDL method in AudioParam.webidl and updating audioparam.rs to send the new UserAutomationEvent to the audio engine.
@jdm
Copy link
Member Author

@jdm jdm commented Feb 15, 2019

Tests: ./mach test-wpt tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface and update the expected results
@ferjm ferjm added this to To do in WebAudio Feb 18, 2019
@Akhilesh1996 Akhilesh1996 mentioned this issue Apr 25, 2019
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Apr 26, 2019
@bors-servo
Auto merge of #23259 - Akhilesh1996:master, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ccff444 
Implement AudioParam.setValueCurveAtTime #22897

<!-- Please describe your changes on the following line: -->
Updated audioparam.rs to send the new UserAutomationEvent SetValueCurveAtTime to the audio engine and updated test results.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22897 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23259)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2019
@bors-servo
Auto merge of #23259 - Akhilesh1996:master, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
06c8563 
Implement AudioParam.setValueCurveAtTime #22897

<!-- Please describe your changes on the following line: -->
Updated audioparam.rs to send the new UserAutomationEvent SetValueCurveAtTime to the audio engine and updated test results.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22897 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23259)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2019
@bors-servo
Auto merge of #23259 - Akhilesh1996:master, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
10bee0d 
Implement AudioParam.setValueCurveAtTime #22897

<!-- Please describe your changes on the following line: -->
Updated audioparam.rs to send the new UserAutomationEvent SetValueCurveAtTime to the audio engine and updated test results.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22897 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23259)
<!-- Reviewable:end -->
@atouchet atouchet moved this from To do to Done in WebAudio Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webaudio
Projects
WebAudio
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement AudioParam.setValueCurveAtTime #22897
1 participant
@jdm
You can’t perform that action at this time.