Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement deprecated setPosition and setOrientation methods for AudioListener #22898
Labels
Projects
Comments
bors-servo
added a commit
that referenced
this issue
Apr 27, 2019
Implement deprecated setPosition and setOrientation methods for AudioListener #22898 <!-- Please describe your changes on the following line: --> I have uncommented the two methods SetPosition and SetOrientation in AudioListener.webidl and have included the two methods in the AudioListener.rs file. I have some errors while handling the NotSupported error for the methods. Can you please review the code and help me out with the errors? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23279) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Apr 28, 2019
Implement deprecated setPosition and setOrientation methods for AudioListener #22898 <!-- Please describe your changes on the following line: --> I have uncommented the two methods SetPosition and SetOrientation in AudioListener.webidl and have included the two methods in the AudioListener.rs file. I have some errors while handling the NotSupported error for the methods. Can you please review the code and help me out with the errors? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23279) <!-- Reviewable:end -->
|
This was fixed in #23279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spec: https://webaudio.github.io/web-audio-api/#AudioListener-methods
This requires uncommenting the methods in
AudioListener.webidl, and adding the new methods toaudiolistener.rsso they update the values of the appropriate AudioParam members of AudioListener with the passed arguments. This should avoid an endless series of JS errors when loading http://swooop.playcanvas.com/ in Servo.