Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a smarter strategy to speed up text run shaping #229

Closed
burg opened this issue Nov 21, 2012 · 1 comment
Closed

Use a smarter strategy to speed up text run shaping #229

burg opened this issue Nov 21, 2012 · 1 comment

Comments

@burg
Copy link

@burg burg commented Nov 21, 2012

Gecko, for example, caches shaping results on a per-word basis and then copies the words into a glyph store when shaping is requested. The cache is stored with gfx::Font instances (i.e., tied to a particular size).

This caching reduces the size of inputs and outputs to harfbuzz, and reduces the number of shaping calls. In gecko this mainly is useful for scaling shaping with the number of unique words; in Servo it would be even more useful while we are still doing non-incremental layout (shaping entire text run over and over).

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 24, 2016

Servo now caches shaping results per word.

@mbrubeck mbrubeck closed this May 24, 2016
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Fix render target cache.

Ensure that the render target cache doesn't return a render target that was allocated on this frame.

Fixes servo#184.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.