Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefs.json: swap prefs before building #22970

Closed
paulrouget opened this issue Mar 5, 2019 · 3 comments
Closed

prefs.json: swap prefs before building #22970

paulrouget opened this issue Mar 5, 2019 · 3 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 5, 2019

As of now, we swap the preferences during mach package. libsimpleservo reads prefs.json at compile time. So it should be done before building.
@jdm
Copy link
Member

@jdm jdm commented Mar 5, 2019

Sounds like we should add cargo metadata to rebuild if the pref files change, as well.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 26, 2019

Also I think the android build doesn't always swap prefs correctly, but I'm not sure.

(I'm getting weird behavior here)
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jul 17, 2020

#27304 partly solves this. Preferences are updated in build.rs.
@paulrouget paulrouget mentioned this issue Jul 17, 2020
Merged
bors-servo added a commit that referenced this issue Jul 20, 2020
@bors-servo
Auto merge of #27304 - paulrouget:staticdevtoolsport, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8cf45f4 
UWP: non random port for devtools, and support for custom UWP prefs

packages-prefs.json is now taken into account for libsimpleservo. Making it possible to have custom pref for the UWP builds, removing some weirdness in the way we handle preferences in the hololens code.

This also adds a new set of preferences to control the devtools server startup state, and make the port choice constant across sessions.

Fix #27267
Fix #22970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

UWP: non random port for devtools, and support for custom UWP prefs
3 participants
@jdm @paulrouget @Manishearth
You can’t perform that action at this time.