styleSheet.insertRule('@import url("<url>");', 0) crashes servo #23028
Labels
A-content/css
Interacting with CSS from web content (parsing, serializing, introspection)
C-has-manual-testcase
C-reproduced
I-panic
Servo encounters a panic.
Comments
|
jdm
added
A-content/css
|
To solve this:
|
|
Code: |
7 tasks
bors-servo
pushed a commit
that referenced
this issue
Mar 21, 2019
Work in Progress <!-- Please describe your changes on the following line: --> - [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner - [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule - [ ] add a test for this that verifies that the new stylesheet is actually loaded --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #23028 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Mar 22, 2019
Expose public getter to stylesheet's owner <!-- Please describe your changes on the following line: --> - [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner - [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule - [x] add a test for this that verifies that the new stylesheet is actually loaded --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23028 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Mar 22, 2019
Expose public getter to stylesheet's owner <!-- Please describe your changes on the following line: --> - [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner - [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule - [x] add a test for this that verifies that the new stylesheet is actually loaded --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23028 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Mar 22, 2019
Expose public getter to stylesheet's owner <!-- Please describe your changes on the following line: --> - [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner - [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule - [x] add a test for this that verifies that the new stylesheet is actually loaded --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23028 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Mar 22, 2019
Expose public getter to stylesheet's owner <!-- Please describe your changes on the following line: --> - [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner - [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule - [x] add a test for this that verifies that the new stylesheet is actually loaded --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23028 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With "Expected a stylesheet loader for @import".
Encountered while fixing #23025, had to annotate a wpt as
expected: CRASH.Testcase
The text was updated successfully, but these errors were encountered: