Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal constructor exception in /bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.https.html #23059

Closed
georgeroman opened this issue Mar 19, 2019 · 3 comments

Comments

@georgeroman
Copy link
Contributor

@georgeroman georgeroman commented Mar 19, 2019

▶ Unexpected subtest result in /bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.https.html:
  │ FAIL [expected PASS] gen-characteristic-is-removed
  │   → Illegal constructor.
  │ 
  └ @https://web-platform.test:8443/bluetooth/resources/bluetooth-helpers.js:177:10
@jdm jdm added the A-content/dom label Mar 19, 2019
@jdm
Copy link
Member

@jdm jdm commented Mar 19, 2019

<script>new DOMException('a', 'b')</script>

This runs fine in Firefox and yields the following exception in Servo:

[2019-03-19T17:30:03Z ERROR script::dom::bindings::error] Error at file:///tmp/foo2.html:1:1 Illegal constructor.
@jdm jdm changed the title Intermittent failure in /bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.https.html Illegal constructor exception in /bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.https.html Mar 19, 2019
@jdm
Copy link
Member

@jdm jdm commented Mar 19, 2019

I think we need to add Constructor(optional DOMString message = "", optional DOMString name) to DOMException.webidl like in Firefox: https://searchfox.org/mozilla-central/source/dom/webidl/DOMException.webidl#70

@jdm
Copy link
Member

@jdm jdm commented Mar 19, 2019

Oops, this is a duplicate of #22412.

@jdm jdm closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.