Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updebugmozjs build is broken #23074
Closed
debugmozjs build is broken #23074
Labels
Comments
bors-servo
added a commit
that referenced
this issue
May 4, 2019
Fix magicleap debugmozjs <!-- Please describe your changes on the following line: --> These changes get magicleap servo to compile with `--debugmozjs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23074 and #22069 - [X] These changes do not require tests because we're not building debugmozjs servo for magicleap <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23318) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 8, 2019
Fix magicleap debugmozjs <!-- Please describe your changes on the following line: --> These changes get magicleap servo to compile with `--debugmozjs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23074 and fix #22069 - [X] These changes do not require tests because we're not building debugmozjs servo for magicleap <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23318) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 8, 2019
Fix magicleap debugmozjs <!-- Please describe your changes on the following line: --> These changes get magicleap servo to compile with `--debugmozjs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23074 and fix #22069 - [X] These changes do not require tests because we're not building debugmozjs servo for magicleap <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23318) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 8, 2019
Fix magicleap debugmozjs <!-- Please describe your changes on the following line: --> These changes get magicleap servo to compile with `--debugmozjs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23074 and fix #22069 - [X] These changes do not require tests because we're not building debugmozjs servo for magicleap <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23318) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 8, 2019
Fix magicleap debugmozjs <!-- Please describe your changes on the following line: --> These changes get magicleap servo to compile with `--debugmozjs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23074 and fix #22069 - [X] These changes do not require tests because we're not building debugmozjs servo for magicleap <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23318) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
servo/components/script/script_runtime.rs
Lines 682 to 696 in ba92920