Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure in sampling profiler test #23109

Closed
jdm opened this issue Mar 27, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@jdm
Copy link
Member

commented Mar 27, 2019

     Running target/debug/deps/hang_monitor_tests-d7bcb6b01769dde1
running 3 tests
Enabling profiler.
test test_hang_monitoring_unregister ... ok
Disabling profiler.
Resolving 1/1
test test_sampler ... FAILED
test test_hang_monitoring ... ok
failures:
---- test_sampler stdout ----
thread 'test_sampler' panicked at 'assertion failed: data.len() > 1', components/background_hang_monitor/tests/hang_monitor_tests.rs:49:17
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:200
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:209
   4: <std::panicking::begin_panic::PanicPayload<A> as core::panic::BoxMeUp>::get
             at src/libstd/panicking.rs:482
   5: core::ptr::real_drop_in_place
             at /rustc/0ea22717a1e01fa535534b85a5347a7e49fc79de/src/libstd/panicking.rs:412
   6: hang_monitor_tests::test_sampler
             at components/background_hang_monitor/tests/hang_monitor_tests.rs:49
   7: hang_monitor_tests::test_sampler::{{closure}}
             at components/background_hang_monitor/tests/hang_monitor_tests.rs:16
   8: core::ops::function::FnOnce::call_once
             at /rustc/0ea22717a1e01fa535534b85a5347a7e49fc79de/src/libcore/ops/function.rs:231
   9: <F as alloc::boxed::FnBox<A>>::call_box
             at src/libtest/lib.rs:1513
             at /rustc/0ea22717a1e01fa535534b85a5347a7e49fc79de/src/libcore/ops/function.rs:231
             at /rustc/0ea22717a1e01fa535534b85a5347a7e49fc79de/src/liballoc/boxed.rs:749
  10: panic_unwind::dwarf::eh::read_encoded_pointer
             at src/libpanic_unwind/lib.rs:87
  11: test::run_test::run_test_inner::{{closure}}
             at /rustc/0ea22717a1e01fa535534b85a5347a7e49fc79de/src/libstd/panicking.rs:276
             at /rustc/0ea22717a1e01fa535534b85a5347a7e49fc79de/src/libstd/panic.rs:388
             at src/libtest/lib.rs:1468
failures:
    test_sampler
test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

This is a test I added in #23080 which appears to fail nondeterministically despite my attempts to write in ways that would discourage that.

@jdm jdm added the I-intermittent label Mar 27, 2019

bors-servo added a commit that referenced this issue Mar 31, 2019

Auto merge of #23139 - gterzian:bounded_profiler_with_buffer_feedback…
…, r=jdm

Bound sampler buffer, add length feedback message, fix intermittence in test

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #23109 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23139)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.