Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake WPT sync auto-reviewed #23113
Closed
Make WPT sync auto-reviewed #23113
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Apr 8, 2019
Review WPT sync PRs automatically --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23113 - [x] These changes do not require tests because it's about infrastructure <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23162) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To do this, we need servo/saltfs#950 and then we need to parse the result of this API call to obtain the new pull request number, so we can use https://developer.github.com/v3/issues/comments/#create-a-comment to create a comment that approves the pull request for merging.
This easiest way to do the parsing is probably a regex. The most resilient way of doing it would be to install jq on the mac builders in saltfs, and then use that to parse the HTTP response body.