Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PKG_CONFIG_PATH automatically when necessary from mach #23177

Closed
CYBAI opened this issue Apr 8, 2019 · 2 comments
Closed

Set PKG_CONFIG_PATH automatically when necessary from mach #23177

CYBAI opened this issue Apr 8, 2019 · 2 comments

Comments

@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented Apr 8, 2019

From #23015 , we found PKG_CONFIG_PATH is required for building Servo.
So, I sent another PR (#23175) to add the README note.

We should be able to set the env var automatically from mach when there's no existing one.

We can do it like following line

append_to_path_env(path.join(libpath, "pkgconfig"), env, "PKG_CONFIG_PATH")

As @ferjm mentioned in IRC, we only need to set the PKG_CONFIG_PATH environment variable when the pkg-config check fails. So, we can do the check once, then set env var if the check fails. If it still fails, then we will throw the error because it might be related to other issues.

@CYBAI CYBAI added the A-mach label Apr 8, 2019
@highfive
Copy link

@highfive highfive commented Apr 8, 2019

@o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented Aug 8, 2019

Oh I just posted in a closed issue, sorry about that: #23015 (comment) :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.