Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet PKG_CONFIG_PATH automatically when necessary from mach #23177
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #23015 , we found
PKG_CONFIG_PATHis required for building Servo.So, I sent another PR (#23175) to add the README note.
We should be able to set the env var automatically from
machwhen there's no existing one.We can do it like following line
servo/python/servo/command_base.py
Line 620 in 3e81a5a
As @ferjm mentioned in IRC, we only need to set the
PKG_CONFIG_PATHenvironment variable when thepkg-configcheck fails. So, we can do the check once, then set env var if the check fails. If it still fails, then we will throw the error because it might be related to other issues.