Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocumentation: Python virtualenv is not installed. #23210
Comments
|
Hello @jdm This looks like a chicken-and-egg problem. Virtualenv is an os package, intended to be installed with servo/python/mach_bootstrap.py Line 254 in c0ee759 servo/python/mach_bootstrap.py Line 245 in c0ee759 Does it make sense to install virtualenv with pip (if it's not already installed) instead or raising the error? |
|
It would certainly be nice if it could be installed automatically. |
|
@jdm So, because I might not have pip, I'd either have to employ a more involved, rudimentary technique in order to discover the linux distro (and possibly version) or just add instructions to documentation and remove the few packages from the bootstrap command? Personally, I'd rather do the latter and start checking out the rust code. |
Fixes servo#23210 Closes servo#23212
Fixes servo#23210 Closes servo#23212
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
I have no problem packaging that, or distros have no problem packaging that, just knowing it is needed would be nice. |
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This should be part of the installation instructions.
Simply recommend it in all the build instructions.
Thanks a lot