Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mach update-manifest command can fail with mozilla metadata #23214

Open
gterzian opened this issue Apr 16, 2019 · 1 comment
Open

Mach update-manifest command can fail with mozilla metadata #23214

gterzian opened this issue Apr 16, 2019 · 1 comment
Labels

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Apr 16, 2019

See #22769 (review)

It looks like a previous call to ./mach update-manifest had added a /_mozilla/mozilla/ entry to tests/wpt/mozilla/meta/MANIFEST.json , which then made test-tidy fail in the following way:

File "/servo/tests/wpt/web-platform-tests/tools/manifest/item.py", line 68, in __init__
    assert url[0] != "/"

Subsequent calls to update-manifest failed silently.

The fix was to explicitly run ./mach test-wpt --manifest-update tests/wpt/mozilla/tests/mozilla/ --manifest tests/wpt/mozilla/meta/MANIFEST.json.

We could update update-manifest to have it deal with such a situation automatically.

@gterzian gterzian mentioned this issue Apr 16, 2019
0 of 5 tasks complete
@jdm
Copy link
Member

@jdm jdm commented Apr 16, 2019

I suspect this is a specialized issue where the PR was made before a WPT sync that updated the manifest format, and then the manifest update code did not see any change in the file in question and therefore did not rebuild its manifest entry. Probably touching the file would have made it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.