Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMach update-manifest command can fail with mozilla metadata #23214
Comments
|
I suspect this is a specialized issue where the PR was made before a WPT sync that updated the manifest format, and then the manifest update code did not see any change in the file in question and therefore did not rebuild its manifest entry. Probably touching the file would have made it work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #22769 (review)
It looks like a previous call to
./mach update-manifesthad added a/_mozilla/mozilla/entry totests/wpt/mozilla/meta/MANIFEST.json, which then madetest-tidyfail in the following way:Subsequent calls to
update-manifestfailed silently.The fix was to explicitly run
./mach test-wpt --manifest-update tests/wpt/mozilla/tests/mozilla/ --manifest tests/wpt/mozilla/meta/MANIFEST.json.We could update
update-manifestto have it deal with such a situation automatically.