Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audioparam tests seem to have lots of failures with the specific values #23271

Open
Manishearth opened this issue Apr 25, 2019 · 0 comments
Open

Audioparam tests seem to have lots of failures with the specific values #23271

Manishearth opened this issue Apr 25, 2019 · 0 comments

Comments

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 25, 2019

Many of the AudioParam test results problems like these in the tests that ensure that the waveforms match:

[X Max error for test 87 at offset 116423 is not less than or equal to 0.000001865. Got 0.039968519116250927.]

It seems like something is being offset or perhaps the values are just completely wrong. Servo and Firefox do sound the same with the same AudioParam JS though.

We should compare the actual waveforms and see what's going on. We've had offset issues before so I wouldn't be surprised if a small offset was being introduced somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.