Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new Japanese era (Reiwa) #23314

Closed
CYBAI opened this issue May 3, 2019 · 11 comments
Closed

Support the new Japanese era (Reiwa) #23314

CYBAI opened this issue May 3, 2019 · 11 comments

Comments

@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented May 3, 2019

URL: https://reiwa-yet.glitch.me/

Bugzilla for Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1543641

In Firefox Nightly:
FirefoxNightly

In Servo
Servo

@KiChjang
Copy link
Member

@KiChjang KiChjang commented May 3, 2019

This looks like a JavaScript engine issue rather than a browser issue, since Intl.DatTimeFormat is defined in https://www.ecma-international.org/ecma-402/2.0/#sec-intl-datetimeformat-constructor. Closing as this can be supported by simply upgrading to the latest SM version.

@KiChjang KiChjang closed this May 3, 2019
@jdm
Copy link
Member

@jdm jdm commented May 3, 2019

Let's leave it open to track the fact that it's broken until we upgrade to a version that fixes it.

@jdm jdm reopened this May 3, 2019
@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented May 4, 2019

@KiChjang Thanks for pointing it! What @jdm said is what I think :)

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jul 6, 2019

Seems this is fixed.

@jdm
Copy link
Member

@jdm jdm commented Jul 6, 2019

Screen Shot 2019-07-05 at 10 40 09 PM

Not in the latest macOS nightly build that I tried.
@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jul 6, 2019

Oops, I tried this on Windows and it says Yes. (Does it depend on OS?)

@atouchet
Copy link
Contributor

@atouchet atouchet commented Jul 6, 2019

I tried it on Windows and it says Yes for me as well briefly before the page crashes in the latest nightly build.

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jul 6, 2019

@atouchet Same here, it's #23531.

@atouchet
Copy link
Contributor

@atouchet atouchet commented Jul 27, 2019

I can get this page to load without crashing now.

@jdm are you using a release with the latest SpiderMonkey updates?

@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented Jul 27, 2019

Works for me on macOS 10.14.5 too!

image

I supposed it's fixed by smup at #23587 👀
Wait for @jdm 's confirmation to close this issue! 😄

@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented Jul 29, 2019

I just tried to go through the bugzilla and the comment 23 said it's fixed for version 67 and our #23587 was for smup 67.

So, I believe it's fixed for Servo as well! Let me close this issue then 😄 Thanks!

@CYBAI CYBAI closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.