Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance interface's timing member should be an attribute #23330

Closed
jdm opened this issue May 6, 2019 · 15 comments
Closed

Performance interface's timing member should be an attribute #23330

jdm opened this issue May 6, 2019 · 15 comments
Labels
A-content/dom A-perf-measurement C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented May 6, 2019

Per https://w3c.github.io/navigation-timing/#extensions-to-the-performance-interface we should have a timing attribute in our WebIDL interface, not a method.

Code: components/script/dom/webidls/Performance.webidl, components/script/dom/performance.rs
Tests: ./mach test-wpt tests/wpt/web-platform-tests/navigation-timing/
@highfive
Copy link

@highfive highfive commented May 6, 2019

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@garyemerson
Copy link

@garyemerson garyemerson commented May 11, 2019

@highfive: assign me

Just got setup to build the project, excited to contribute! Looks like just the Performance.webidl would need to be changed, right? I'll try that out and see if it builds.
@highfive highfive added the C-assigned label May 11, 2019
@highfive
Copy link

@highfive highfive commented May 11, 2019

Hey @garyemerson! Thanks for your interest in working on this issue. It's now assigned to you!
@garyemerson garyemerson mentioned this issue May 11, 2019
Closed
3 of 5 tasks complete
bors-servo added a commit that referenced this issue May 13, 2019
@bors-servo
Auto merge of #23367 - garyemerson:timing_webidl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ddf1b8e 
Change Performance interface's timing member to an attribute

<!-- Please describe your changes on the following line: -->
Change Performance interface's timing member to an attribute

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23330 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] These changes do not require tests because ___
- [ ] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23367)
<!-- Reviewable:end -->
@jdm jdm removed the C-assigned label Jul 12, 2019
@jdm
Copy link
Member Author

@jdm jdm commented Jul 12, 2019

#23367 had a patch that looked good, but needed some test results to be updated before the author disappeared.
@bcamp
Copy link

@bcamp bcamp commented Jul 15, 2019

@highfive: assign me

Looks like #23332 went in and the test no longer needs updating.
@highfive highfive added the C-assigned label Jul 15, 2019
@highfive
Copy link

@highfive highfive commented Jul 15, 2019

Hey @bcamp! Thanks for your interest in working on this issue. It's now assigned to you!
@bcamp bcamp mentioned this issue Jul 15, 2019
Closed
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Jul 15, 2019
@bors-servo
Auto merge of #23773 - bcamp:timing_to_attr, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a64745 
Changed performance interface's timing to an attribute

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23330 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23773)
<!-- Reviewable:end -->
@jdm jdm added E-easy and removed E-easy C-assigned labels Sep 4, 2019
@highfive
Copy link

@highfive highfive commented Sep 4, 2019

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@jdm
Copy link
Member Author

@jdm jdm commented Sep 4, 2019

There was a partial solution in #23773, but it exposed some issues which need to be resolved per my latest comment there.
@stephenmuss
Copy link
Contributor

@stephenmuss stephenmuss commented Sep 6, 2019

I'd be happy to have a crack.

@highfive: assign me
@highfive highfive added the C-assigned label Sep 6, 2019
@highfive
Copy link

@highfive highfive commented Sep 6, 2019

Hey @stephenmuss! Thanks for your interest in working on this issue. It's now assigned to you!
@jdm
Copy link
Member Author

@jdm jdm commented Oct 10, 2019

Unassigning due to lack of activity.
@jdm jdm removed the C-assigned label Oct 10, 2019
@tomasdivito
Copy link
Contributor

@tomasdivito tomasdivito commented Oct 11, 2019

I will take a look :)

@highfive: assign me
@highfive highfive added the C-assigned label Oct 11, 2019
@highfive
Copy link

@highfive highfive commented Oct 11, 2019

Hey @tomasdivito! Thanks for your interest in working on this issue. It's now assigned to you!
@tomasdivito tomasdivito mentioned this issue Oct 16, 2019
Closed
4 of 5 tasks complete
@jdm jdm removed the C-assigned label Nov 11, 2019
@shnmorimoto
Copy link
Contributor

@shnmorimoto shnmorimoto commented Dec 7, 2019

@highfive: assign me
@highfive highfive added the C-assigned label Dec 7, 2019
@highfive
Copy link

@highfive highfive commented Dec 7, 2019

Hey @shnmorimoto! Thanks for your interest in working on this issue. It's now assigned to you!
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 7, 2019
@shnmorimoto
servo#23330 modified performance interface's timing member to attribute
3e7337a
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 7, 2019
@shnmorimoto
servo#23330 updated test
9a5eb43
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 7, 2019
@shnmorimoto
servo#23330 modified performance interface's timing member to attribute
243eb5e
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 7, 2019
@shnmorimoto
servo#23330 updated test
2e91f26
@shnmorimoto shnmorimoto mentioned this issue Dec 7, 2019
Merged
4 of 4 tasks complete
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 11, 2019
@shnmorimoto
servo#23330 updated test
46eeaf9
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 11, 2019
@shnmorimoto
servo#23330 fix clear_entries_by_name_and_type bug
b0cabb7
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 11, 2019
@shnmorimoto
servo#23330 fix clear_entries_by_name_and_type bug
aba4f0e
bors-servo added a commit that referenced this issue Dec 11, 2019
@bors-servo
Auto merge of #25205 - shnmorimoto:fix_performance_interface_timing_m…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a60282 
…ember, r=<try>

Fix performance interface timing member

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23330 and #24468 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 modified performance interface's timing member to attribute
3edbcca
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 fix clear_entries_by_name_and_type bug
dadd054
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 updated test
70cad4f
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 modified performance interface's timing member to attribute
758cd44
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 fix clear_entries_by_name_and_type bug
184b630
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 updated test
eba6655
bors-servo added a commit that referenced this issue Dec 13, 2019
@bors-servo
Auto merge of #25205 - shnmorimoto:fix_performance_interface_timing_m…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b6f4c9b 
…ember, r=<try>

Fix performance interface timing member

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23330 and #24468 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 updated test
e3d61cd
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 fix clear_entries_by_name_and_type bug
4d3938c
shnmorimoto added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto
servo#23330 fix clear_entries_by_name_and_type bug
9017b12
jdm added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto @jdm
servo#23330 modified performance interface's timing member to attribute
2457a6b
jdm added a commit to shnmorimoto/servo that referenced this issue Dec 13, 2019
@shnmorimoto @jdm
servo#23330 fix clear_entries_by_name_and_type bug
7d184c1
bors-servo added a commit that referenced this issue Dec 13, 2019
@bors-servo
Auto merge of #25205 - shnmorimoto:fix_performance_interface_timing_m…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
293f10f 
…ember, r=jdm

Fix performance interface timing member

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23330 and #24468 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Dec 13, 2019
@bors-servo
Auto merge of #25205 - shnmorimoto:fix_performance_interface_timing_m…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f811bfa 
…ember, r=jdm

Fix performance interface timing member

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23330 and #24468 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Dec 13, 2019
@bors-servo
Auto merge of #25205 - shnmorimoto:fix_performance_interface_timing_m…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
483f907 
…ember, r=jdm

Fix performance interface timing member

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23330 and #24468 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-perf-measurement C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix performance interface timing member
Change Performance interface's timing member to an attribute
Changed performance interface's timing to an attribute
Performance interface's timing member as an attribute change
7 participants
@jdm @stephenmuss @shnmorimoto @tomasdivito @garyemerson @highfive @bcamp
You can’t perform that action at this time.