Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPermissions prompt support in Servo #23376
Comments
|
There is some overlap with the work for #23057, too. |
|
Where is the code that scan for media devices? In Servo or in the embedder? |
|
It's currently in Gstreamer. This can be changed to make it an embedder hook. The primary goal of this issue is to have some ability to throw up a permissions prompt, we can extend that for |
|
Hello, I started looking at this issue. I followed jdm's link to #23057, I see how #20428 and #20429 moved use of tinyfiledialogs to the embedder. I saw
that this issue refers to? If so, what's the difference and where should it go? Thanks. |
|
Manish's statement wasn't completely correct. Servo does partially support the DOM Permissions API, but only displays prompts for bluetooth-related permissions checks and only on Linux. We will need to add DOM Permissions API integration into Servo's GetUserMedia implementation, but first we should create the right infrastructure for that by fixing #23057, which is really the issue that I intended to send you. |
|
Cool, I'll look at #23057 then. |
|
We're going to need hooks for permissions prompts in embedder stuff for Hololens, at least cc @paulrouget Immersive mode is supposed to trigger permissions prompts in many cases. |
|
I like the prompt service we have in Gecko: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/windowwatcher/nsIPromptService.idl Would that work for your use cases (getUserMedia and immersive mode)? |
|
Probably yeah. We'd need some kind of embedder API and a native implementation for the hololens. |
|
WIP https://github.com/paulrouget/servo/tree/prompt |
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.
Currently Servo cannot trigger permissions prompts. This is going to be necessary to be able to expose
getUserMedia()and some of the XR stuff.This will likely be somewhere in the embedder API.
Ideally, for
getUserMedia()we can have a "pick your device" menu as well (may need a separate API)cc @paulrouget