Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing on Fedora 30 #23454

Closed
mboros1 opened this issue May 24, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@mboros1
Copy link

commented May 24, 2019

The bootstrap succeeded, when I tried to build it failed. Running mach check I get the following error:

    Checking tokio-current-thread v0.1.1
    Checking tokio-timer v0.2.6
   Compiling unwind-sys v0.1.1
   Compiling style v0.0.1 (/home/martinboros/Source/servo/components/style)
error: failed to run custom build command for `unwind-sys v0.1.1`
process didn't exit successfully: `/home/martinboros/Source/servo/target/debug/build/unwind-sys-2335baf783224ab6/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failure { command: "\"pkg-config\" \"--libs\" \"--cflags\" \"libunwind-generic\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Package libunwind-generic was not found in the pkg-config search path.\nPerhaps you should add the directory containing `libunwind-generic.pc\'\nto the PKG_CONFIG_PATH environment variable\nPackage \'libunwind-generic\', required by \'virtual:world\', not found\n" } }', src/libcore/result.rs:999:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

Looks like a package is not being added?

@jdm

This comment has been minimized.

Copy link
Member

commented May 24, 2019

You need to re-run mach bootstrap.

@jdm

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Sorry, didn't read correctly. Add libunwind-devel to the bootstrap code, I suppose?

@mboros1

This comment has been minimized.

Copy link
Author

commented May 25, 2019

I could have sworn I already tried that but yes that fixed it. I'll make a PR to fix it and the README to add it, thank you

bors-servo added a commit that referenced this issue May 25, 2019

Auto merge of #23455 - mboros1:master, r=emilio
Add missing dependency to build servo in Fedora 30

<!-- Please describe your changes on the following line: -->
Add missing dependency libunwind-devel to mach bootstrap for dnf and updating README file to reflect changes

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23454 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because mach build tests it

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23455)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.