Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are unresponsive after starting #23489

Closed
jdm opened this issue May 31, 2019 · 5 comments
Closed

Windows builds are unresponsive after starting #23489

jdm opened this issue May 31, 2019 · 5 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented May 31, 2019

I suspect this was introduced in #23457, since the window changes sizes frequently and contains large black areas.

@jdm
Copy link
Member Author

@jdm jdm commented May 31, 2019

Confirmed. This regressed in #23457, based on running local builds made before and after that change.

@jdm
Copy link
Member Author

@jdm jdm commented May 31, 2019

I made a build with 0.20 and it worked, so that at least narrows the range.

@jdm
Copy link
Member Author

@jdm jdm commented May 31, 2019

@jdm
Copy link
Member Author

@jdm jdm commented May 31, 2019

@paulrouget Is there any chance this is triggered by the implementation in https://github.com/servo/servo/blob/master/ports/glutin/context.rs rather than the changes in rust-windowing/glutin@90f0ef4?

@jdm
Copy link
Member Author

@jdm jdm commented Jun 1, 2019

rust-windowing/glutin#1163 (comment) points out that our code that calls window.set_inner_size in response to the Resize event is wrong. When I fix that the flickering resizing window goes away, but Servo remains unresponsive. This is caused by the Resize window event that Servo enqueues causes a synchronous repaint to occur, except no composite is scheduled so the compositor is hung indefinitely and no window events can be processed that might trigger one.

@jdm jdm mentioned this issue Jun 1, 2019
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jun 4, 2019
Fix behaviour of window resizing on Windows.

This makes Windows builds usable when the window is resized.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23489
- [x] These changes do not require tests because we can't run tests on Windows CI yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23497)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.