Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWindows builds are unresponsive after starting #23489
Comments
|
Confirmed. This regressed in #23457, based on running local builds made before and after that change. |
|
I made a build with 0.20 and it worked, so that at least narrows the range. |
|
Filed rust-windowing/glutin#1163. |
|
@paulrouget Is there any chance this is triggered by the implementation in https://github.com/servo/servo/blob/master/ports/glutin/context.rs rather than the changes in rust-windowing/glutin@90f0ef4? |
|
rust-windowing/glutin#1163 (comment) points out that our code that calls window.set_inner_size in response to the Resize event is wrong. When I fix that the flickering resizing window goes away, but Servo remains unresponsive. This is caused by the Resize window event that Servo enqueues causes a synchronous repaint to occur, except no composite is scheduled so the compositor is hung indefinitely and no window events can be processed that might trigger one. |
Fix behaviour of window resizing on Windows. This makes Windows builds usable when the window is resized. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23489 - [x] These changes do not require tests because we can't run tests on Windows CI yet. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23497) <!-- Reviewable:end -->
I suspect this was introduced in #23457, since the window changes sizes frequently and contains large black areas.