Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`./mach check` errors while `./mach build --dev` builds. #23513

Open
gatoWololo opened this issue Jun 4, 2019 · 3 comments
Open

`./mach check` errors while `./mach build --dev` builds. #23513

gatoWololo opened this issue Jun 4, 2019 · 3 comments
Labels

Comments

@gatoWololo
Copy link
Contributor

@gatoWololo gatoWololo commented Jun 4, 2019

I currently have a successfully building Servo with ./mach build --dev:

gatowololo@omar-mozilla ~/S/servo> ./mach build --dev
   Compiling script v0.0.1 (/home/gatowololo/Servo/servo/components/script)
   Compiling layout_thread v0.0.1 (/home/gatowololo/Servo/servo/components/layout_thread)
   Compiling libservo v0.0.1 (/home/gatowololo/Servo/servo/components/servo)
   Compiling servo v0.0.1 (/home/gatowololo/Servo/servo/ports/glutin)

... Warning messages...

    Finished dev [unoptimized + debuginfo] target(s) in 1m 26s
Build Completed in 0:01:26

But ./mach check fails:

gatowololo@omar-mozilla ~/S/servo> ./mach check
   Compiling script v0.0.1 (/home/gatowololo/Servo/servo/components/script)
    Checking canvas v0.0.1 (/home/gatowololo/Servo/servo/components/canvas)
error[E0425]: cannot find function `create_backend` in this scope
   --> components/canvas/canvas_data.rs:411:23
    |
411 |         let backend = create_backend();
    |                       ^^^^^^^^^^^^^^ not found in this scope

error[E0392]: parameter `'a` is never used
   --> components/canvas/canvas_data.rs:379:23
    |
379 | pub struct CanvasData<'a> {
    |                       ^^ unused parameter
    |
    = help: consider removing `'a` or using a marker such as `std::marker::PhantomData`

error[E0392]: parameter `'a` is never used
  --> components/canvas/canvas_paint_thread.rs:18:30
   |
18 | pub struct CanvasPaintThread<'a> {
   |                              ^^ unused parameter
   |
   = help: consider removing `'a` or using a marker such as `std::marker::PhantomData`

error[E0392]: parameter `'a` is never used
   --> components/canvas/canvas_data.rs:366:24
    |
366 | pub enum StrokeOptions<'a> {
    |                        ^^ unused parameter
    |
    = help: consider removing `'a` or using a marker such as `std::marker::PhantomData`

error[E0392]: parameter `'a` is never used
    --> components/canvas/canvas_data.rs:1099:29
     |
1099 | pub struct CanvasPaintState<'a> {
     |                             ^^ unused parameter
     |
     = help: consider removing `'a` or using a marker such as `std::marker::PhantomData`

error: aborting due to 5 previous errors

Some errors have detailed explanations: E0392, E0425.
For more information about an error, try `rustc --explain E0392`.
error: Could not compile `canvas`.
warning: build failed, waiting for other jobs to finish...
error: build failed

Not sure if I'm doing something wrong?

I'm running:

Ubuntu 19.04
Kernel: 5.0.0-15-generic
cargo 1.36.0-nightly (759b6161a 2019-05-06)
@jdm
Copy link
Member

@jdm jdm commented Jun 4, 2019

Bleah, that's a regression from #23451. You can work around with with ./mach check --features azure_backend.

@jdm jdm added the I-bustage label Jun 4, 2019
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jun 9, 2019

How does one fix this? Is it a matter of invoking cargo via the python scripts with the right feature flags?

@jdm
Copy link
Member

@jdm jdm commented Jun 9, 2019

The answer is to hard code the features flag in the python that invokes cargo check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.