Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS nightlies can't play media (no such element factory "appsrc") #23519

Closed
jdm opened this issue Jun 5, 2019 · 3 comments
Closed

macOS nightlies can't play media (no such element factory "appsrc") #23519

jdm opened this issue Jun 5, 2019 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 5, 2019

STR: visit http://dragonites.glitch.me/ in a nightly build

godot:MacOS jdm$ GST_DEBUG=2 ./servo http://dragonites.glitch.me/
A-Frame Version: 0.6.1 (Date 19-07-2017, Commit #a4b91bc)
three Version:
^0.84.0
WebVR Polyfill Version:
^0.9.36
Could not stop player Backend("Missing dependency: playbin")
Could not stop player Backend("Missing dependency: playbin")
[physics] `debug` cannot be changed dynamically.
[object Object]
%cpreset: goaland
color: #f48;font-weight:bold
%ccore:schema:warn %cUnknown property `color` for component/system `material`.%c
color: orange
color: inherit
color: orange
0:00:01.164200000 51993 0x7ffe0a765290 WARN     GST_ELEMENT_FACTORY gstelementfactory.c:456:GstElement *gst_element_factory_make(const gchar *, const gchar *): no such element factory "appsrc"!
Could not start audio render thread: Backend("appsrc creation failed") (thread AudioRenderThread, at src/libcore/result.rs:999)
[2019-06-05T16:29:40Z ERROR servo] Could not start audio render thread: Backend("appsrc creation failed")
called `Result::unwrap()` on an `Err` value: RecvError (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }, at src/libcore/result.rs:999)
[2019-06-05T16:29:41Z ERROR servo] called `Result::unwrap()` on an `Err` value: RecvError
@jdm jdm changed the title macOS nightlies can't play media macOS nightlies can't play media (no such element factory "appsrc") Jun 5, 2019
@ferjm
Copy link
Member

@ferjm ferjm commented Jun 6, 2019

Missing dependency: playbin means that gst-plugins-base is not installed.

AFAICT we are not deploying GStreamer with Servo's OSX package.

@jdm jdm mentioned this issue Jul 5, 2019
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 5, 2019
Support WebAudio on Windows

These changes improve the GStreamer experience on Windows in several ways:
* we package the set of plugins and their dependencies that Servo requires for media support
* we explicitly load those plugins when starting the media engine rather than relying on an existing gstreamer installation

These changes do not affect the experience on non-Windows platforms, but the path is clear to do so in order to fix problems like #23519. With these changes I can successfully hear a tone when loading https://joshmatthews.net/osc.html in both a desktop build and a UWP build.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23631 and fix #23698
- [x] These changes do not require tests because no tests on windows ;_;

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23712)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 8, 2019
Support WebAudio on Windows

These changes improve the GStreamer experience on Windows in several ways:
* we package the set of plugins and their dependencies that Servo requires for media support
* we explicitly load those plugins when starting the media engine rather than relying on an existing gstreamer installation

These changes do not affect the experience on non-Windows platforms, but the path is clear to do so in order to fix problems like #23519. With these changes I can successfully hear a tone when loading https://joshmatthews.net/osc.html in both a desktop build and a UWP build.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23631 and fix #23698
- [x] These changes do not require tests because no tests on windows ;_;

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23712)
<!-- Reviewable:end -->
@nicoabie
Copy link

@nicoabie nicoabie commented Jul 29, 2020

@jdm It does play media now on MacOS 10.15.6!

@jdm
Copy link
Member Author

@jdm jdm commented Jul 29, 2020

Glad to know my efforts to fix media in macOS nightlies have not been in vain!

@jdm jdm closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.