Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmacOS nightlies can't play media (no such element factory "appsrc") #23519
Labels
Comments
|
AFAICT we are not deploying GStreamer with Servo's OSX package. |
bors-servo
added a commit
that referenced
this issue
Jul 5, 2019
Support WebAudio on Windows These changes improve the GStreamer experience on Windows in several ways: * we package the set of plugins and their dependencies that Servo requires for media support * we explicitly load those plugins when starting the media engine rather than relying on an existing gstreamer installation These changes do not affect the experience on non-Windows platforms, but the path is clear to do so in order to fix problems like #23519. With these changes I can successfully hear a tone when loading https://joshmatthews.net/osc.html in both a desktop build and a UWP build. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23631 and fix #23698 - [x] These changes do not require tests because no tests on windows ;_; <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23712) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 8, 2019
Support WebAudio on Windows These changes improve the GStreamer experience on Windows in several ways: * we package the set of plugins and their dependencies that Servo requires for media support * we explicitly load those plugins when starting the media engine rather than relying on an existing gstreamer installation These changes do not affect the experience on non-Windows platforms, but the path is clear to do so in order to fix problems like #23519. With these changes I can successfully hear a tone when loading https://joshmatthews.net/osc.html in both a desktop build and a UWP build. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23631 and fix #23698 - [x] These changes do not require tests because no tests on windows ;_; <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23712) <!-- Reviewable:end -->
|
@jdm It does play media now on MacOS 10.15.6! |
|
Glad to know my efforts to fix media in macOS nightlies have not been in vain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
STR: visit http://dragonites.glitch.me/ in a nightly build