Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upconfigure script failing #236
Closed
Comments
|
Sigh. Fixed with the latest push. One of these days I'll figure out how to not have the submodules all go to non-master branches on me. |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this issue
Sep 7, 2014
Fix syntax errors
glennw
pushed a commit
to glennw/servo
that referenced
this issue
Jan 16, 2017
Use signed arithmetic to avoid underflow when shrinking window. fixes servo#236 The underflow occurs when the y co-ordinate of `viewport_size` in the last `render_api.set_root_stacking_context` call is bigger than the y co-ordinate of `framebuffer_size` in a `renderer.render` call. The problem is the calculated layer_origin y is negative, but we calculate it using unsigned ints, and then cast to signed just for the gl calls. The two places where this calculated value is used are `gl::scissor` and `gl::viewport`, both of these are perfectly happy with a negative origin point (as far as I know and can tell, but I don't have much experience with opengl), thus I've just changed it so we cast to signed integers early. The other options would be to require the above doesn't happen, either by using an outdated bigger framebuffer size (which results in the contents of the window moving upwards as the window shrinks), or recalling `set_root_stacking_context` (which is less efficient).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just tried to build with d15dd2f and it appears that the change to the src/rust-freetype module in the most recent commit means that
git submodule updatewill fail, and therefore, so will./configure:Checking out the previous commit (be1935e) fixes it (well, to the extent that I can get a servo executable, at least).