Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force LF on .gitattributes #23608

Closed
saschanaz opened this issue Jun 23, 2019 · 1 comment
Closed

Force LF on .gitattributes #23608

saschanaz opened this issue Jun 23, 2019 · 1 comment
Labels
I-papercut

Comments

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jun 23, 2019 •
edited

A local clone on Windows by default gets CRLF, which makes hard to build it on WSL. Can we add * text=auto eol=lf to use LF consistently? (Or perhaps * -text?)
@jdm
Copy link
Member

@jdm jdm commented Jun 23, 2019

That sounds like a useful improvement to me. We should do that for https://github.com/servo/mozjs as well.
@jdm jdm added the I-papercut label Jun 23, 2019
This was referenced Jun 24, 2019
Merged
Merged
bors-servo added a commit to servo/mozjs that referenced this issue Jun 24, 2019
@bors-servo
Auto merge of #187 - saschanaz:patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b539bf1 
Prevent CRLF conversion on Windows

As @jdm suggested in servo/servo#23608.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/187)
<!-- Reviewable:end -->
bors-servo added a commit to servo/mozjs that referenced this issue Jun 25, 2019
@bors-servo
Auto merge of #187 - saschanaz:patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e2062a 
Prevent CRLF conversion on Windows

As @jdm suggested in servo/servo#23608.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/187)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 25, 2019
@bors-servo
Auto merge of #23613 - saschanaz:patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5126d9 
Prevent CRLF conversion on Windows

@jdm Do you prefer `text=auto` or `-text` (seems to be default on Linux, not sure on macOS)?

Closes #23608

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23613)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-papercut
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Prevent CRLF conversion on Windows
2 participants
@jdm @saschanaz
You can’t perform that action at this time.