Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI test that verifies that `mach check` works #23659

Closed
jdm opened this issue Jun 28, 2019 · 2 comments
Closed

Add a CI test that verifies that `mach check` works #23659

jdm opened this issue Jun 28, 2019 · 2 comments
Labels
A-testing I-papercut

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 28, 2019

We keep breaking it when playing around with cargo features. We should stop breaking it!
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jun 28, 2019

There’s a bunch of logic in ./mach build before calling cargo build. Most of it should likely apply to ./mach check as well.
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jun 29, 2019

Also ./mach doc has similar logic that should be unified with both build and check. Compare:

servo/python/servo/build_commands.py

Lines 307 to 308 in 84786ad

if "raqote_backend" not in features:
features += ["azure_backend"]

servo/python/servo/post_build_commands.py

Line 267 in 84786ad

params += ["--features", "azure_backend"]

SimonSapin added a commit that referenced this issue Jul 1, 2019
@SimonSapin
Share more `./mach build` logic with mach check, doc, test-unit
ed68c3c 
Fixes #23659
@SimonSapin SimonSapin mentioned this issue Jul 1, 2019
Merged
SimonSapin added a commit that referenced this issue Jul 1, 2019
@SimonSapin
Share more `./mach build` logic with mach check, doc, test-unit
d05126f 
Fixes #23659
SimonSapin added a commit that referenced this issue Jul 1, 2019
@SimonSapin
Share more `./mach build` logic with mach check, doc, test-unit
06f4c7d 
Fixes #23659
bors-servo added a commit that referenced this issue Jul 2, 2019
@bors-servo
Auto merge of #23676 - servo:check, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c5663d 
Share more `./mach build` logic with mach check, doc, test-unit

Fixes #23659

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23676)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Jul 2, 2019
@SimonSapin
Share more `./mach build` logic with mach check, doc, test-unit
50e3e56 
Fixes #23659
bors-servo added a commit that referenced this issue Jul 2, 2019
@bors-servo
Auto merge of #23676 - servo:check, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c02d5cf 
Share more `./mach build` logic with mach check, doc, test-unit

Fixes #23659

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23676)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Jul 2, 2019
@SimonSapin
Share more `./mach build` logic with mach check, doc, test-unit
7c85dc0 
Fixes #23659
bors-servo added a commit that referenced this issue Jul 2, 2019
@bors-servo
Auto merge of #23676 - servo:check, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e19b889 
Share more `./mach build` logic with mach check, doc, test-unit

Fixes #23659

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23676)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 3, 2019
@bors-servo
Auto merge of #23676 - servo:check, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
865ed91 
Share more `./mach build` logic with mach check, doc, test-unit

Fixes #23659

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23676)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 3, 2019
@bors-servo
Auto merge of #23676 - servo:check, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5003387 
Share more `./mach build` logic with mach check, doc, test-unit

Fixes #23659

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23676)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing I-papercut
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Share more `./mach build` logic with mach check, doc, test-unit
2 participants
@jdm @SimonSapin
You can’t perform that action at this time.