Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upServo dispatches too many disconnected callbacks. #23716
Labels
Comments
|
Filed whatwg/dom#773 since the spec is wrong on this one I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found this while reviewing #23208, though it's pre-existing and probably dates back to the initial custom-elements implementation.
ScriptThread::enqueue_callback_reactionis called withCallbackReaction::Disconnectedevery time a node is unbound from a tree, but that is not correct. That bit should be conditional on the node being connected before, since otherwise you get callbacks for stuff like removing a custom element in a already-unbound subtree.cc @cbrewster @jdm