Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo dispatches too many disconnected callbacks. #23716

Open
emilio opened this issue Jul 5, 2019 · 1 comment
Open

Servo dispatches too many disconnected callbacks. #23716

emilio opened this issue Jul 5, 2019 · 1 comment
Labels

Comments

@emilio
Copy link
Member

@emilio emilio commented Jul 5, 2019

I found this while reviewing #23208, though it's pre-existing and probably dates back to the initial custom-elements implementation.

ScriptThread::enqueue_callback_reaction is called with CallbackReaction::Disconnected every time a node is unbound from a tree, but that is not correct. That bit should be conditional on the node being connected before, since otherwise you get callbacks for stuff like removing a custom element in a already-unbound subtree.

cc @cbrewster @jdm

@emilio emilio changed the title Servo dispatch too many disconnected callbacks. Servo dispatches too many disconnected callbacks. Jul 5, 2019
@emilio
Copy link
Member Author

@emilio emilio commented Jul 5, 2019

Filed whatwg/dom#773 since the spec is wrong on this one I believe.

@emilio emilio added the A-content/dom label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.