Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServoApp can't launch when packaged with UWP GStreamer binaries #23742

Closed
jdm opened this issue Jul 10, 2019 · 2 comments
Closed

ServoApp can't launch when packaged with UWP GStreamer binaries #23742

jdm opened this issue Jul 10, 2019 · 2 comments
Labels
A-build P-hololens
Projects
HoloLens UWP port Windows ARM64

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 10, 2019

With jdm@8dd3f87 applied, launching the UWP Servo app triggers a panic when it can't load any of the GStreamer plugins. They all depend on vcruntime140_app.dll and msvcrt_app.dll which aren't present in the generated AppX.
@jdm
Copy link
Member Author

@jdm jdm commented Jul 10, 2019

More specifically, with that commit applied and the x86_64 binaries from https://nirbheek.in/files/mozilla/uwp/gstreamer/0.3/ packaged by setting GSTREAMER_1_0_ROOT_X86_64 appropriately during the Servo build.
@atouchet atouchet added this to To do in HoloLens Jul 15, 2019
@jdm
Copy link
Member Author

@jdm jdm commented Jul 24, 2019

I have successfully launched the x64 UWP app using the UWP gstreamer binaries. I'm putting together a pull request that will add them to the MSVC dependencies and use them in the build when --uwp is applied.
@jdm jdm added this to To do in UWP port via automation Jul 24, 2019
@jdm jdm added this to To do in Windows ARM64 via automation Jul 24, 2019
@jdm jdm moved this from To do to In progress in HoloLens Jul 24, 2019
@jdm jdm moved this from To do to In progress in Windows ARM64 Jul 26, 2019
@jdm jdm moved this from To do to In progress in UWP port Jul 26, 2019
@jdm jdm mentioned this issue Jul 26, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 26, 2019
@bors-servo
Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c31b47c 
Various UWP GStreamer improvements

There are a number of positive changes in these commits:
* we successfully load GStreamer plugins in ARM64 UWP builds
* we correctly link the ARM64 ANGLE libraries when appropriate
* it is no longer necessary to manually set the LIB environment variable on Windows
* we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp`
* the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them
* the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23742
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 26, 2019
@bors-servo
Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5369df5 
Various UWP GStreamer improvements

There are a number of positive changes in these commits:
* we successfully load GStreamer plugins in ARM64 UWP builds
* we correctly link the ARM64 ANGLE libraries when appropriate
* it is no longer necessary to manually set the LIB environment variable on Windows
* we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp`
* the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them
* the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23742
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 26, 2019
@bors-servo
Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d76c0ec 
Various UWP GStreamer improvements

There are a number of positive changes in these commits:
* we successfully load GStreamer plugins in ARM64 UWP builds
* we correctly link the ARM64 ANGLE libraries when appropriate
* it is no longer necessary to manually set the LIB environment variable on Windows
* we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp`
* the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them
* the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23742
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 26, 2019
@bors-servo
Auto merge of #23863 - jdm:gstreamer-uwp, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27d369b 
Various UWP GStreamer improvements

There are a number of positive changes in these commits:
* we successfully load GStreamer plugins in ARM64 UWP builds
* we correctly link the ARM64 ANGLE libraries when appropriate
* it is no longer necessary to manually set the LIB environment variable on Windows
* we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp`
* the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them
* the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23742
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 27, 2019
@bors-servo
Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b9b0176 
Various UWP GStreamer improvements

There are a number of positive changes in these commits:
* we successfully load GStreamer plugins in ARM64 UWP builds
* we correctly link the ARM64 ANGLE libraries when appropriate
* it is no longer necessary to manually set the LIB environment variable on Windows
* we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp`
* the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them
* the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23742
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)
<!-- Reviewable:end -->
UWP port automation moved this from In progress to Done Jul 27, 2019
Windows ARM64 automation moved this from In progress to Done Jul 27, 2019
@atouchet atouchet moved this from In progress to Done in HoloLens Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build P-hololens
Projects
HoloLens
  
Done
UWP port
  
Done
Windows ARM64
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Various UWP GStreamer improvements
1 participant
@jdm
You can’t perform that action at this time.