Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appveyor is broken after gstreamer packaging changes #23749

Closed
jdm opened this issue Jul 11, 2019 · 5 comments
Closed

Appveyor is broken after gstreamer packaging changes #23749

jdm opened this issue Jul 11, 2019 · 5 comments
Labels
A-build A-infrastructure P-windows

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 11, 2019

Same symptoms as #23747 except that it's our own CI.
@jdm
Copy link
Member Author

@jdm jdm commented Jul 11, 2019

Hmm, we're installing both the devel and non-devel packages already :<
@jdm jdm mentioned this issue Jul 11, 2019
Closed
@jdm
Copy link
Member Author

@jdm jdm commented Jul 11, 2019 

ackaging gstreamer DLLs
ERROR: could not find required GStreamer DLL: avfilter-7.dll
ERROR: could not find required GStreamer DLL: avformat-58.dll
ERROR: could not find required GStreamer DLL: avcodec-58.dll
ERROR: could not find required GStreamer DLL: avutil-56.dll
ERROR: could not find required GStreamer DLL: swresample-3.dll

servo/appveyor.yml

Lines 53 to 56 in 5bc34e3

- appveyor-retry appveyor DownloadFile https://gstreamer.freedesktop.org/data/pkg/windows/1.16.0/gstreamer-1.0-devel-msvc-x86_64-1.16.0.msi
- appveyor-retry appveyor DownloadFile https://gstreamer.freedesktop.org/data/pkg/windows/1.16.0/gstreamer-1.0-msvc-x86_64-1.16.0.msi
- msiexec /i gstreamer-1.0-devel-msvc-x86_64-1.16.0.msi /quiet /qn /norestart /log install-devel.log
- msiexec /i gstreamer-1.0-msvc-x86_64-1.16.0.msi /quiet /qn /norestart /log install.log

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jul 11, 2019

I can get the files from ffmpeg Windows build and copy-paste them into gstreamer directory, but then it fails again with:

**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.0
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
    Finished dev [unoptimized + debuginfo] target(s) in 17.85s
Packaging gstreamer DLLs
ERROR: could not find required GStreamer DLL: gstlibav.dll
Packaging MSVC DLLs
Build FAILED in 0:00:18
@jdm
Copy link
Member Author

@jdm jdm commented Jul 11, 2019

One interesting difference between our Taskcluster CI and Appveyor is that appveyor installs the MSIs with /quiet, meaning that any default options will be automatically used. Taskcluster extracts all of the files from the MSI and repackages them in a ZIP which is later unpacked in the directory that Servo's build uses. This suggests to me that the MSI contains a choice to install the ffmpeg DLLs which is not enabled by default.
@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jul 11, 2019 •
edited

Ah, you're right! The installer has a disabled-by-default option named "GStreamer 1.0 libav wrapper" which installs the required files.
@jdm jdm mentioned this issue Jul 11, 2019
Closed
bors-servo added a commit that referenced this issue Jul 12, 2019
@bors-servo
Auto merge of #23752 - servo:jdm-patch-38, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a7b4af8 
Add build option to ignore packaging errors.

Works around #23749.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23752)
<!-- Reviewable:end -->
@UK992 UK992 mentioned this issue Jul 12, 2019
Merged
bors-servo added a commit that referenced this issue Jul 13, 2019
@bors-servo
Auto merge of #23765 - UK992:appveyor, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
30ca50a 
Appveyor: Fix missing gstreamer dlls

This changes will execute complete installation of gstreamer. And should fix #23749

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23765)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build A-infrastructure P-windows
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Appveyor: Fix missing gstreamer dlls
2 participants
@jdm @saschanaz
You can’t perform that action at this time.