Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mach: update-manifest misses local changes #23775

Open
gterzian opened this issue Jul 15, 2019 · 3 comments
Open

mach: update-manifest misses local changes #23775

gterzian opened this issue Jul 15, 2019 · 3 comments
Labels

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Jul 15, 2019

I've noticed a few times that if you make a change to an existing test, ./mach update-manifest does nothing locally. Later, it fails on CI(example: https://tools.taskcluster.net/groups/Sl1yBFfwRP6Vh2ELmd8Hxw/tasks/CebOEynkQruZJ-A0FGfYrQ/runs/0/logs/public%2Flogs%2Flive.log#L525).

Not sure how I fixed it last time, or whether this happens intermittently, but this time I can guarantee that I tried it a few times locally, I even deleted MANIFEST.json and rebuild it, yet it was rebuild without taking into account the latest changes(0f53873#diff-684fc482ea12f526b30118a7d4cfa714R33).

@gterzian gterzian added the L-python label Jul 15, 2019
@highfive
Copy link

@highfive highfive commented Jul 15, 2019

@gterzian gterzian changed the title mach: update-manifest doesn't catch local changes mach: update-manifest misses local changes Jul 15, 2019
@jdm
Copy link
Member

@jdm jdm commented Jul 15, 2019

I'm hopeful that this has been fixed by web-platform-tests/wpt#17785.

@CYBAI CYBAI added the A-mach label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.