Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del element is not shown as deleted #23779

Open
CYBAI opened this issue Jul 16, 2019 · 3 comments
Open

del element is not shown as deleted #23779

CYBAI opened this issue Jul 16, 2019 · 3 comments

Comments

@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented Jul 16, 2019

While checking the html5accessibility testing page, I found we didn't show <del> element correctly.

Firefox:
image

Servo:
image

Also, this makes me notice that looks like we pass the del element test case bogusly 🤔 cc @emilio

image

Note: Built based on latest master on macOS 10.14.5

@CYBAI CYBAI added the A-content/css label Jul 16, 2019
@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented Jul 16, 2019

The simplest test case is

<del>test deleted</del>

image

@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented Jul 16, 2019

Also, this makes me notice that looks like we pass the del element test case bogusly 🤔

Hmm, maybe I shouldn't say it's bogus because we do have the css attribute in

del, s, strike { text-decoration: line-through; }

But maybe we can test it better with a reftest? 🤔

@CYBAI CYBAI removed the A-content/css label Jul 16, 2019
@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented Jul 16, 2019

Maybe this is related to #17887 👀?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.