Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck for user activation in WebXR #23787
Comments
Enable XR WPT tests This enables the tests. Most still fail, I plan to go through the failures more soon. xrFrame_getPose's failure seems to indicate we have broken matrix math. I'm not sure what, the bug seems to not come from a simple matrix inversion/ordering mishap. This does add empty stubs for session ending since the test infra relies on these existing for almost every test (#23788). We will need to add support for this from the webxr repo side. We also need to add support for user activation (#23787). r? @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23786) <!-- Reviewable:end -->
|
@paulrouget This is another platform piece we're missing if you're interested. We need to track when we're firing input events that originated from the user so that code like requestSession can check if it's safe to enter. |
|
is there a DOM specification about that? I remember vaguely something about user clicks vs. js clicks. |
|
Properly classifying events as trusted doesn't look difficult. Not sure where to store this property to make it accessible from any DOM call though. Is it possible to "tag" a js call? Gecko appears to use a static ( |
|
Making it a property of ScriptThread and adding a static method might makes sense. |
requestSession()is not supposed to work in immersive mode if it isn't triggered by user activation. We should also updatesimulateUserActivation()from #23786 when implementing this.