Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simpleservo.h is not placed in arm64 target directory #23794

Closed
jdm opened this issue Jul 17, 2019 · 2 comments
Closed

simpleservo.h is not placed in arm64 target directory #23794

jdm opened this issue Jul 17, 2019 · 2 comments
Labels
A-build P-hololens
Projects
UWP port Windows ARM64

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 17, 2019

It seems to be hardcoded to target/debug or target/release, but --target aarch64-pc-windows-msvc should cause it to be placed in target/aarch64-pc-windows-msvc/{debug,release} instead.
@jdm jdm added this to To do in UWP port via automation Jul 17, 2019
@jdm
Copy link
Member Author

@jdm jdm commented Jul 17, 2019

This occurs because the build script is not cross-compiled, so its target directory is actually the root target/.
@jdm
Copy link
Member Author

@jdm jdm commented Jul 22, 2019

We can fix this by explicitly by creating a path based on TARGET (if it's different from the host) and PROFILE using the current directory as the base path.
@jdm jdm added this to To do in Windows ARM64 Jul 22, 2019
@jdm jdm mentioned this issue Jul 23, 2019
Merged
4 of 4 tasks complete
@jdm jdm moved this from To do to In progress in Windows ARM64 Jul 23, 2019
bors-servo added a commit that referenced this issue Jul 24, 2019
@bors-servo
Auto merge of #23830 - servo:jdm-patch-43, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
750526d 
Generate simpleservo.h in appropriate target directory.

This change makes the C API's build script take the the actual build target into account when generating the C header.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23794
- [x] These changes do not require tests because no tests for UWP build.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23830)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 24, 2019
@bors-servo
Auto merge of #23830 - servo:jdm-patch-43, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9151e2d 
Generate simpleservo.h in appropriate target directory.

This change makes the C API's build script take the the actual build target into account when generating the C header.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23794
- [x] These changes do not require tests because no tests for UWP build.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23830)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 24, 2019
@bors-servo
Auto merge of #23830 - servo:jdm-patch-43, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
55cea0d 
Generate simpleservo.h in appropriate target directory.

This change makes the C API's build script take the the actual build target into account when generating the C header.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23794
- [x] These changes do not require tests because no tests for UWP build.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23830)
<!-- Reviewable:end -->
UWP port automation moved this from To do to Done Jul 24, 2019
Windows ARM64 automation moved this from In progress to Done Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build P-hololens
Projects
UWP port
  
Done
Windows ARM64
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Generate simpleservo.h in appropriate target directory.
1 participant
@jdm
You can’t perform that action at this time.