Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate NuGet package for ANGLE with ARM64 support #23809
Closed
Labels
Projects
Comments
|
https://www.nuget.org/packages/ANGLE.WindowsStore.Servo/2.1.13 Time to update our documentation! |
|
Nevermind, I need to update the package reference in the project file. |
bors-servo
added a commit
that referenced
this issue
Jul 24, 2019
Use Servo's ANGLE fork for UWP. This package is built from https://github.com/servo/ms-angle/tree/servo-master and gives us ARM64 and x86_64 binaries for ANGLE. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23809 - [x] These changes do not require tests because there are no tests for ANGLE on Windows UWP. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23829) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 24, 2019
Use Servo's ANGLE fork for UWP. This package is built from https://github.com/servo/ms-angle/tree/servo-master and gives us ARM64 and x86_64 binaries for ANGLE. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23809 - [x] These changes do not require tests because there are no tests for ANGLE on Windows UWP. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23829) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The official Microsoft ANGLE NuGet package has x64, x86, and ARM support. We need ARM64 as well, and microsoft/angle#144 is just sitting there waiting. I propose we make our own fork of that repository, merge that pull request and microsoft/angle#154 and then publish the resulting binaries as our own NuGet package.
https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package-using-visual-studio
https://docs.microsoft.com/en-us/nuget/create-packages/native-packages
https://docs.microsoft.com/en-us/nuget/nuget-org/publish-a-package
https://shed.globalgraphics.com/2018/03/15/creating-a-native-c-nuget-package-for-the-mako-sdk/