Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand wpt lint to cover moz suite as well #23897

Open
gterzian opened this issue Jul 31, 2019 · 2 comments
Open

Expand wpt lint to cover moz suite as well #23897

gterzian opened this issue Jul 31, 2019 · 2 comments
Labels

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Jul 31, 2019

There is a wpt lint that checks for stuff like leaving a console.log in a test file, at
https://github.com/servo/servo/blob/510ffde3f18d02f19be1e90baa903239922a8e49/python/servo/lints/wpt_lint.py

However, it doesn't seem to work for tests added to the "mozilla" folder, see https://github.com/servo/servo/pull/23887/files#r309177019

The "mozilla" folder is at https://github.com/servo/servo/tree/510ffde3f18d02f19be1e90baa903239922a8e49/tests/wpt/mozilla/tests/mozilla

Could be an error in the python code using the wrong filepath...

@gterzian gterzian added the L-python label Jul 31, 2019
@highfive
Copy link

@highfive highfive commented Jul 31, 2019

@gterzian
Copy link
Member Author

@gterzian gterzian commented Jul 31, 2019

A good way to check your fix is simply doing ./mach test-tidy, since we currently have a console.log checked-in, it should fail. Then you could also remove it, so that your PR would actually pass CI...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.