Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three.js examples broke on recent three.js releases #23954

Closed
asajeffrey opened this issue Aug 12, 2019 · 3 comments
Closed

Three.js examples broke on recent three.js releases #23954

asajeffrey opened this issue Aug 12, 2019 · 3 comments

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Aug 12, 2019

The three.js examples which used to work in Servo are now not rendering.

Bisecting using the wayback machine, Mar 31 works, https://web.archive.org/web/20190331203342/https://threejs.org/examples/#webgl_animation_cloth but May 9 doesn't https://web.archive.org/web/20190509071159/https://threejs.org/examples/#webgl_animation_cloth

This could be r104 switching off error checking for shader compilation? https://github.com/mrdoob/three.js/wiki/Migration-Guide#r103--r104

@jdm
Copy link
Member

@jdm jdm commented Aug 12, 2019

This is caused by the switch to use JS modules in the examples instead: see discussion at mrdoob/three.js#16799 (comment) which includes workarounds.

@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Aug 12, 2019

Ah, that explains it!

@jdm
Copy link
Member

@jdm jdm commented Nov 20, 2019

Closing this since the cause it known.

@jdm jdm closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.