Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsimpleservo ignores ShowIME and HideIME events #23969

Closed
asajeffrey opened this issue Aug 14, 2019 · 1 comment
Closed

libsimpleservo ignores ShowIME and HideIME events #23969

asajeffrey opened this issue Aug 14, 2019 · 1 comment
Labels
A-embedding

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Aug 14, 2019

The HideIME and ShowIME events are ignored by libsimpleservo:

servo/ports/libsimpleservo/api/src/lib.rs

Lines 571 to 574 in c475755

EmbedderMsg::ShowIME(..) |
EmbedderMsg::HideIME |
EmbedderMsg::Panic(..) |
EmbedderMsg::ReportProfile(..) => {},

@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Aug 14, 2019

The root cause of #22983. cc @paulrouget
This was referenced Aug 14, 2019
Open
Open
@paulrouget paulrouget mentioned this issue Aug 19, 2019
Merged
bors-servo added a commit that referenced this issue Aug 22, 2019
@bors-servo
Auto merge of #23999 - paulrouget:missingCMethods, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e19484 
Missing C methods

Depends on #23983

Fix #23969

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-embedding
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Missing C methods
1 participant
@asajeffrey
You can’t perform that action at this time.