Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[hololens] Move ServoControl to its own project #24020
Comments
|
STR:
I also tried to not import ServoComponent and step by step migrate the code to the winrt template, but I always end up hitting this issue. The fact I can't rename Class to Servo is very unnerving. @angelortiz1007 can you help? |
|
Paul, I have not forgotten about you. I'm working on it and will have some observations soon. Angel |
|
Paul, So I followed your first 2 bullet items and I did get a failure to build the new component. I got the C3544 error along with others such as: So, if you can, can you try again creating a Winrt component. This time do the following:
This should do it. Let me know if it works for you. Note: winrt\base.h will get recreated each time you make a change to the .h, .cpp, or the .idl file. Hope this gets you past the error. |
|
I was doing all of these steps already. But still getting the error. Did it work for you? |
|
It did. Hummmm
…On Fri, Aug 23, 2019, 22:59 Paul Rouget ***@***.***> wrote:
I was doing all of these steps already. But still getting the error. Did
it work for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24020?email_source=notifications&email_token=AMJITWGXZ47TGSEAEYOMURDQGCWZ3A5CNFSM4IOBPMS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BX4IQ#issuecomment-524516898>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMJITWEE3JO42NPIO5DNL23QGCWZ3ANCNFSM4IOBPMSQ>
.
|
|
One thing I forgot, but sure you did too is to in the *.idl file. namespace RuntimeComponent3
{
[default_interface]
runtimeclass Class
{
Class();
Int32 MyProperty;
}
}To namespace RuntimeComponent3
{
[default_interface]
runtimeclass Servo
{
Servo();
Int32 MyProperty;
}
}Here is my renamed/worked on servo.h Make certain your VS2017 is up to date with SDK and patches. Make certain VS2017 does a clean of the solution. Make certain the module.g.cpp shows Servo instead of Class. Here is output from my build: |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Will do! By the way, my contract will be ending in 2 weeks. Do you know of any other managers that need C/C++ developers in Windows/UNIX/Linux? |
|
Check with @jdm. |
|
@angelortiz1007 Yeah I done all of the things you mention. But still no luck. Did you manage to compile a project named "Servo" within the hololens solution? Can you look at this branch: https://github.com/paulrouget/servo/tree/ServoProject - the last commit doesn't compile. I have no idea why. |
|
Paul, I tried a clone and was not able to get all the files. Not even a git checkout HEAD. Can you verify the repository checks out for you? |
|
Hmm, there's nothing special here. It works. In your servo directory:
|
|
Hmmm.... C:\git-mozilla\servo-angelortiz2>git remote add paul git@github.com:paulrouget/servo.git C:\git-mozilla\servo-angelortiz2>git checkout -b ServoProject paul/ServoProject |
|
I think I have to clone your https://github.com/paulrouget/servo/tree/ServoProject then do the git checkout. In either case, when I did a clone of https://github.com/paulrouget/servo/tree/ServoProject it didn't download all the files. C:\git-mozilla\servo-angelortiz2>git remote -v |
|
You need to run |
|
So, something is not going well for me. I've done: git clone https://github.com/paulrouget/servo.git paulrouget cd paulrouget2 C:\git-mozilla\paulrouget2>git status Changes to be committed: C:\git-mozilla\paulrouget2>git remote -v C:\git-mozilla\paulrouget2>git remote add paul git@github.com:paulrouget/servo.git C:\git-mozilla\paulrouget2>git remote -v C:\git-mozilla\paulrouget2> C:\git-mozilla\paulrouget2>git fetch origin ServoProject
C:\git-mozilla\paulrouget2> C:\git-mozilla\paulrouget2>git checkout -b ServoProject paul/ServoProject C:\git-mozilla\paulrouget2>git checkout -b ServoProject origin/ServoProject C:\git-mozilla\paulrouget2> |
|
Your checkout is failing. This is because my version of Servo's repository master branch has an invalid file. But not in the branch I shared with you. You don't need another clone of servo. 2 options: In a already successfully checked-out servo directory: Or, a new clone (I fixed the file issue): To verify you are on the right branch: Should show commit 05df345. |
|
OK. The 2nd option worked for me after you resolved the files issue. I'm currently building servo then hololens. Just to be clear, it is hololens that is failing, correct? BTW................. C:\git-mozilla\servo-angelortiz2>git fetch paul Please make sure you have the correct access rights C:\git-mozilla\servo-angelortiz2>git remote -v |
|
git@ remotes don't work without the correct SSH keys present. https://github.com/paulrouget/servo.git as the remote would work instead. |
|
Paul, I got my environment setup. Yep, this is a strange one. I'm still working through it and believe it has to do with the Servo and ServoT structs. The servo.g.h file has: The first error below is related - I believe - to the additional errors below it. The {ctor} error points to line I got to look at it more. See what you uncover tonight and if what I'm saying rings a bell. I'll continue in the morning. |
I need help here. I've tried, but failed to create a 2nd project in the solution that would host the ServoControl code only, and make the ServoApp project use that control.
I'm sure it's simple but I don't know how to create a simple winrt project that uses a
Generic.xamlfile. I keep hitting different compilation issues. Same when I'm trying to remove or rename theclass.*files from the winrt template.