Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do something about HoloLens C++ code formating #24031

Closed
paulrouget opened this issue Aug 22, 2019 · 0 comments
Closed

Do something about HoloLens C++ code formating #24031

paulrouget opened this issue Aug 22, 2019 · 0 comments
Labels
P-hololens

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 22, 2019

Visual Studio can format the whole file based on the clang-format file.

It's not done automatically, but it, sometimes, happens (on pasting for example).

That means we get some random syntax changes in pull requests. For example: #24030

We should enable tidy for hololens code, and figure out the right formatting.
@paulrouget paulrouget mentioned this issue Oct 25, 2019
Merged
bors-servo added a commit that referenced this issue Nov 4, 2019
@bors-servo
Auto merge of #24552 - paulrouget:clangformat, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5caa241 
mach fmt calls clang-format

Fix #24031

What would be the right way to also integrate this with tidy?
bors-servo added a commit that referenced this issue Nov 4, 2019
@bors-servo
Auto merge of #24552 - paulrouget:clangformat, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e0d81e1 
mach fmt calls clang-format

Fix #24031

What would be the right way to also integrate this with tidy?
@bors-servo bors-servo closed this in f626355 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-hololens
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

mach fmt calls clang-format
1 participant
@paulrouget
You can’t perform that action at this time.