Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing a TTY with a pipe to `cat` suppresses error codes #24071

Open
jdm opened this issue Aug 27, 2019 · 1 comment
Open

Forcing a TTY with a pipe to `cat` suppresses error codes #24071

jdm opened this issue Aug 27, 2019 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 27, 2019

There are a bunch of tests in the macOS taskcluster WPT jobs that use | cat on the end of the command to force a TTY so an appropriate logging choice is made. Unfortunately, this suppresses the error code, so any of those jobs could be silently busted and taskcluster wouldn't notice.

@jdm
Copy link
Member Author

@jdm jdm commented Aug 27, 2019

We can fix this by passing --log-mach - instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.