Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWarn when module scripts are ignored #24089
Closed
Labels
Comments
|
This keeps biting people when they try out three.js examples. We really need to raise the visibility of the problem. |
|
Working on it! Will cherry-pick some commits from #23545 and |
bors-servo
added a commit
that referenced
this issue
Sep 6, 2019
Show warning when module scripts are ignored The first five commits are `cherry-pick`-ed from the module script PR. I think it might be also good to have this PR first so that reviewers can focus on module script things on that PR! --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24089 - [x] These changes do not require tests because it just ignored module scripts (or should we turn on module script tests in this PR and update those test expectation to TIMEOUT?) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24142) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 6, 2019
Show warning when module scripts are ignored The first five commits are `cherry-pick`-ed from the module script PR. I think it might be also good to have this PR first so that reviewers can focus on module script things on that PR! --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24089 - [x] These changes do not require tests because it just ignored module scripts (or should we turn on module script tests in this PR and update those test expectation to TIMEOUT?) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24142) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an ongoing source of confusion when pages don't work that depend on module scripts. We should log a warning when they are encountered as long as we don't support them.