Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't connect to devtools from firefox nightly #24092

Closed
jdm opened this issue Aug 28, 2019 · 5 comments
Closed

Can't connect to devtools from firefox nightly #24092

jdm opened this issue Aug 28, 2019 · 5 comments
Assignees
@jdm
Labels
A-devtools I-bustage

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 28, 2019 

[ACTION FAILED] CONNECT_RUNTIME_FAILURE: Can't find the actor ID for preference from root or target actor's form.
@highfive
Copy link

@highfive highfive commented Aug 28, 2019

cc @fitzgen
@jdm
Copy link
Member Author

@jdm jdm commented Aug 28, 2019

Based on https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/devtools/client/aboutdebugging/src/modules/client-wrapper.js#106 we appear to be missing actors for preferences.
@saschanaz saschanaz mentioned this issue Oct 5, 2019
Merged
4 of 4 tasks complete
@paulrouget paulrouget mentioned this issue Dec 3, 2019
Closed
@jdm
Copy link
Member Author

@jdm jdm commented Dec 10, 2019

https://searchfox.org/mozilla-central/rev/690e903ef689a4eca335b96bd903580394864a1c/devtools/server/actors/utils/actor-registry.js#124 looks like a good reference.
@jdm
Copy link
Member Author

@jdm jdm commented Dec 11, 2019

WIP branch at https://github.com/jdm/servo/tree/devtools-revival. This gets us to the point where the about:debugging interface for a remote Servo loads, but clicking the "Inspect" button for a tab yields a JS exception.
@jdm
Copy link
Member Author

@jdm jdm commented Dec 13, 2019

Latest changes on that branch allow us to inspect a tab and get a usable JS console. I'll make a pull request once I've finished cleaning it up.
@jdm jdm self-assigned this Dec 13, 2019
@jdm jdm mentioned this issue Dec 13, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 14, 2019
@bors-servo
Auto merge of #25288 - jdm:devtools-revival, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
644a83d 
Update devtools server for Firefox 71.

Based on reading code under https://searchfox.org/mozilla-central/source/devtools/shared/specs/, https://searchfox.org/mozilla-central/source/devtools/shared/front/, https://searchfox.org/mozilla-central/source/devtools/shared/specs/, and https://searchfox.org/mozilla-central/source/devtools/server/actors/, as well as dumping the protocol output when using Firefox to debug itself. This makes the JS console usable again in nightly Firefox from about:debugging.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24092
- [x] These changes do not require tests because ha ha ha devtools tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-devtools I-bustage
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Update devtools server for Firefox 71.
2 participants
@jdm @highfive
You can’t perform that action at this time.