Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Servo branding in UWP app with Firefox Reality #24108

Closed
jdm opened this issue Aug 29, 2019 · 4 comments
Closed

Replace Servo branding in UWP app with Firefox Reality #24108

jdm opened this issue Aug 29, 2019 · 4 comments
Labels
I-cleanup P-hololens
Projects
HoloLens

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 29, 2019

We should remove references to Servo (ServoApp in title, servo:// url handler) from the app and replace them with Firefox Reality instead. We should also create some store asset icons that make use of the FxR logo.
@jdm jdm added this to To do in HoloLens Aug 29, 2019
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 30, 2019

Should we add, like in Firefox, a branding configuration file for app names and icons?
@jdm
Copy link
Member Author

@jdm jdm commented Aug 30, 2019

What would be the purpose of making it configurable?
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 30, 2019

The UWP app can also be used as a regular Windows Desktop app.
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 30, 2019

Doesn't matter for now, could be a follow-up for the day it's necessary.
@paulrouget paulrouget mentioned this issue Sep 3, 2019
Merged
bors-servo added a commit that referenced this issue Sep 4, 2019
@bors-servo
Auto merge of #24125 - paulrouget:branding, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db93ddb 
Branding: s/servo/firefox reality/

- Used images from https://github.com/MozillaReality/FirefoxReality
- Used description from https://play.google.com/store/apps/details?id=org.mozilla.vrbrowser
- Changed protocol handler url scheme from "servo://" to "fxr://"
- Default page for now is about:blank

Fix #24108

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24125)
<!-- Reviewable:end -->
@bors-servo bors-servo closed this in d611892 Sep 6, 2019
@jdm jdm moved this from To do to Done in HoloLens Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-cleanup P-hololens
Projects
HoloLens
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Branding: s/servo/firefox reality/
2 participants
@jdm @paulrouget
You can’t perform that action at this time.