Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Windows openssl binaries to a UWP-compatible version #24138
Comments
jdm
changed the title
|
It might be possible to cherry-pick openssl/openssl@5ded1ca and ensure that the binaries are built with the appropriate C define and /APPCONTAINER flags. |
|
1.1.1d was released but the changes from https://github.com/winkelsdorf/openssl/pull/224 were not backported to it. |
bors-servo
added a commit
that referenced
this issue
Sep 23, 2019
Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 23, 2019
Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 24, 2019
Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 24, 2019
Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/servo/openssl-windows-build
https://github.com/servo/openssl/tree/servo
https://github.com/servo/openssl-src-rs/tree/servo
These are currently building 1.1.1c. The UWP changes in upstream openssl are more recent than that, and my attempt to update the openssl submodule to an appropriate revision ran into build problems in openssl-sys because the openssl version macros changed :(