Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper and rust-url disagree about how to parse URLs #24175

Open
asajeffrey opened this issue Sep 10, 2019 · 0 comments
Open

Hyper and rust-url disagree about how to parse URLs #24175

asajeffrey opened this issue Sep 10, 2019 · 0 comments

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Sep 10, 2019

In the http_loader we convert URLs from rust-url to hyper, for example when constructing a Referer at

.typed_insert::<Referer>(http_request_referrer.to_string().parse().unwrap()),

The problem is that this may fail, because rust-url and hyper have different parsers, for example rust-url accepts http://"empty_script.js/?id=5\\%22 but hyper doesn't. This came up during testing. #24148 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.