Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser window stays maximized after exiting fullscreen mode #24200

Closed
ferjm opened this issue Sep 12, 2019 · 1 comment
Closed

Browser window stays maximized after exiting fullscreen mode #24200

ferjm opened this issue Sep 12, 2019 · 1 comment
Labels
A-embedding

Comments

@ferjm
Copy link
Member

@ferjm ferjm commented Sep 12, 2019

STR:

Expected:

  • Clicking on the Hide Fullscreen button minimizes the browser and changes the background color back to white.

Current behaviour:

  • Clicking on the Hide Fullscreen button changes the background color back to white, but the browser stays maximized.
@ferjm ferjm mentioned this issue Sep 12, 2019
Closed
@jdm
Copy link
Member

@jdm jdm commented Sep 12, 2019

I think the problem is this line.
@jdm jdm added the A-embedding label Sep 12, 2019
@ferjm ferjm mentioned this issue Sep 20, 2019
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Sep 20, 2019
@bors-servo
Auto merge of #24249 - ferjm:exit.fullscreen, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a6285cd 
Go back to original window size after exiting fullscreen

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24200

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24249)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 20, 2019
@bors-servo
Auto merge of #24249 - ferjm:exit.fullscreen, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a493aa 
Go back to original window size after exiting fullscreen

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24200

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24249)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-embedding
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Go back to original window size after exiting fullscreen
2 participants
@jdm @ferjm
You can’t perform that action at this time.