Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: offscreen gl context panic #24206

Closed
paulrouget opened this issue Sep 13, 2019 · 5 comments
Closed

regression: offscreen gl context panic #24206

paulrouget opened this issue Sep 13, 2019 · 5 comments
Assignees
@jdm
Labels
A-content/webgl C-reproduced I-panic

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Sep 13, 2019

While running: https://www.joshmatthews.net/webgl-to-webxr/webxr-ar.html

thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `1280`,
 right: `0`', C:\Users\paul\.cargo\registry\src\github.com-1ecc6299db9ec823\offscreen_gl_context-0.25.0\src\draw_buffer.rs:125:9
@paulrouget paulrouget closed this Sep 13, 2019
@paulrouget paulrouget reopened this Sep 13, 2019
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Sep 13, 2019

I suspect 1cefae7
@jdm
Copy link
Member

@jdm jdm commented Sep 13, 2019

Is this on Windows? In the HL2 emulator? On device?
@jdm
Copy link
Member

@jdm jdm commented Sep 13, 2019

Apparently check_framebuffer_status is causing a GL error to appear: https://github.com/servo/rust-offscreen-rendering-context/blob/317efd913e52228176155280b7d5a29d5591d1f0/src/draw_buffer.rs#L123-L126
@jdm
Copy link
Member

@jdm jdm commented Sep 13, 2019

I'll see if I can reproduce this today.
@jdm jdm added the C-reproduced label Sep 13, 2019
@jdm
Copy link
Member

@jdm jdm commented Sep 13, 2019

More specifically, it's coming from https://github.com/servo/rust-offscreen-rendering-context/blob/317efd913e52228176155280b7d5a29d5591d1f0/src/draw_buffer.rs#L247-L250 and I'm not yet sure why.
@jdm jdm closed this Sep 13, 2019
@jdm jdm reopened this Sep 13, 2019
@jdm jdm mentioned this issue Sep 13, 2019
Merged
4 of 4 tasks complete
@jdm jdm self-assigned this Sep 13, 2019
bors-servo added a commit that referenced this issue Sep 13, 2019
@bors-servo
Auto merge of #24212 - jdm:sparkleup, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a43e25c 
Update sparkle for GLES fix.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24206
- [x] These changes do not require tests because no GLES tests on CI.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24212)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-content/webgl C-reproduced I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Update sparkle for GLES fix.
2 participants
@jdm @paulrouget
You can’t perform that action at this time.