Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP caching: fix TODOs and take another look at code #24219

Open
gterzian opened this issue Sep 16, 2019 · 1 comment
Open

HTTP caching: fix TODOs and take another look at code #24219

gterzian opened this issue Sep 16, 2019 · 1 comment
Labels

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Sep 16, 2019

As part of #24203 I realized once again there are:

  1. quite a lot of TODOs,
  2. quite a lot of missing pieces not marked as TODOs and maybe even bugs that haven't been noticed yet(the spec might have changed here and there as well),

in the "core" caching logic, which mostly consists of checking headers and cache directives and making decisions based on those.

It would be useful to take another good look at https://github.com/servo/servo/blob/master/components/net/http_cache.rs

in the light of the spec at https://tools.ietf.org/html/rfc7234

The tests are at https://github.com/servo/servo/tree/master/tests/wpt/web-platform-tests/fetch/http-cache, we're passing most of it, see https://github.com/servo/servo/tree/master/tests/wpt/metadata/fetch/http-cache, which means the suite probably requires more tests as well.

@gterzian gterzian added the A-network label Sep 16, 2019
@pshaughn
Copy link
Member

@pshaughn pshaughn commented Jan 25, 2020

#24909 and #24952 are a couple specific omissions I've noticed in caching (though the latter might not fall under what you're thinking of as "caching logic")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.